[wp-trac] [WordPress Trac] #11426: Allow trash option in comment notification emails
WordPress Trac
wp-trac at lists.automattic.com
Tue Dec 15 00:16:08 UTC 2009
#11426: Allow trash option in comment notification emails
--------------------------+-------------------------------------------------
Reporter: nacin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Trash | Version: 2.9
Severity: normal | Keywords: has-patch
--------------------------+-------------------------------------------------
Comment(by nacin):
The AYS screen is needed. If it's removed, you'd get tripped up by
check_admin_referer and you'd have to answer wp_nonce_ays. Not exactly
user-friendly. And removing check_admin_referer, obviously, is backwards
in terms of security/intent.
Adding &email=true or &confirm=true is just another way to skin a cat --
the code would largely be the same -- except that it also unnecessarily
lengthens the URL by something like 18+ characters.
----
Speaking of check_admin_referer, I left one in there that needed to be
removed. Most recent patches are
[http://core.trac.wordpress.org/attachment/ticket/11426/11426.alternative.2.diff
11426.alternative.2.diff] and
[http://core.trac.wordpress.org/attachment/ticket/11426/11426.4.2.diff
11426.4.2.diff] (sorry about the name -- left out pluggable.php in the
diff and forgot to click the "Replace file" checkbox).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11426#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list