[wp-trac] [WordPress Trac] #11401: checks against array('draft', 'pending') should be changed

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 11 19:38:57 UTC 2009


#11401: checks against array('draft', 'pending') should be changed
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:     
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  2.9
Component:  Trash              |     Version:  2.9
 Severity:  normal             |    Keywords:     
-------------------------------+--------------------------------------------
Changes (by nacin):

  * component:  General => Trash


Comment:

 I looked through those instances, and it looks like wp_list_pages() is the
 only function that may be affected. Best I can tell, all other instances
 already filter out trashed posts or have their own trash handlers.

 But the post itself can't be viewed -- you'll get a 404 in the frontend,
 and a wp_die in the backend, so is it really that bad that wp_link_pages()
 doesn't check for it?

 That said, there is an instance that does need to be patched -- while wp-
 comments-posts.php checks for trash status and bails, admin-ajax.php
 doesn't check when replying to comments in wp-admin. I was able to reply
 to a comment on a post that was trashed.

 Two patches forthcoming. One tramples over the string freeze, one doesn't
 but then returns an error message that isn't 100% correct.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11401#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list