[wp-trac] [WordPress Trac] #11384: rewrite->flush() needlessly deletes the rewrite_rules option

[WordPress Trac]

#11384: rewrite->flush() needlessly deletes the rewrite_rules option
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:                 
     Type:  defect (bug)       |      Status:  new            
 Priority:  normal             |   Milestone:  3.0            
Component:  Performance        |     Version:  2.9            
 Severity:  normal             |    Keywords:  early has-patch
-------------------------------+--------------------------------------------
 All sorts of cache-related plugins hook into the
 update_option_rewrite_rules and force-flush whatever they're caching when
 rewrite_rules are updated.

 When a page is saved, WP_Rewrite::flush() mindlessly deletes the
 rewrite_rule option, triggering all sorts of cache flushing that may or
 may not be necessary.

 The attached patch keeps the rewrite_rules option intact when a soft
 refresh occurs.

 Tests done:

  - non-verbose rules used, page changes parent: no refresh
  - verbose rules used, page changes parent: refresh

 Dunno what else needs to be testing...

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11384>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software