[wp-trac] [WordPress Trac] #11315: Versioning is being forced for JavaScript and CSS assets with no override

[WordPress Trac]

#11315: Versioning is being forced for JavaScript and CSS assets with no override
-------------------------+--------------------------------------------------
 Reporter:  amattie      |       Owner:  azaozz
     Type:  enhancement  |      Status:  new   
 Priority:  normal       |   Milestone:  3.0   
Component:  JavaScript   |     Version:  2.9   
 Severity:  normal       |    Keywords:        
-------------------------+--------------------------------------------------

Comment(by amattie):

 Regarding the purpose of this:
 {{{
         235                     if ( $this->ver === false )
 236     236                             $this->ver = false;
 }}}

 You're correct in that that's kinda useless, but perhaps 235-236 should be
 removed altogether then. Without removing it (as it is in
 11315_override.diff or 11315_remove.diff), $this->ver is set to false if
 an empty string is passed in since '' evals to false. If $this->ver is set
 to false (strict) at that point, checking for === false in the other spots
 will become useless.

 In other words, the suggested behavior of setting the value to an empty
 string to override the versioning will have no effect if 235-236 is left
 in there.

 Thoughts on removing 235-236 in _WP_Dependency?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11315#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software