[wp-trac] [WordPress Trac] #11273: Comments: Edit button is not necessary with Quick Edit button
WordPress Trac
wp-trac at lists.automattic.com
Tue Dec 1 22:33:14 UTC 2009
#11273: Comments: Edit button is not necessary with Quick Edit button
-------------------------+--------------------------------------------------
Reporter: lloydbudd | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Comments | Version: 2.9
Severity: normal | Keywords: early
-------------------------+--------------------------------------------------
Comment(by nacin):
Replying to [comment:10 caesarsgrunt]:
> Since needing the current Edit is likely to be a fringe case, why not
either (a) have an Advanced link as previously discussed, or (b) make it
so plugins can add it back if they want it due to other features they add?
That's an interesting idea. I would suggest having an Advanced link AND
allow plugins to add an Edit link to the comment row. Plugins can already
modify the action links using the comment_row_action filter. But, instead
of forcing them to rebuild the URL, I'm thinking we should then create a
way for plugins to easily do so.
First route: {{{ if ( ! apply_filters( 'comment_row_action_edit', false )
) unset( $action['edit'] ); }}}
Second route: Default filter on comment_row_action to remove
$action['edit'], which could then be removed by a plugin. This seems to
make more sense but would probably confuse a plugin developer looking at
_wp_comment_row() and not realizing there is a default filter at work.
Also, there should be a way to moderate / change the status of a comment
from Quick Edit. Currently, when you click Quick Edit, you lose the action
links. (This is true and is a UI issue now, but when you make Quick Edit
primary, it comes more into focus.)
> After all, most things which are added to the Edit page could equally
well be added to Quick Edit.
Actually... looking through comment.php, I don't see a single hook, which
given the new comment meta in 2.9 is pretty important. Am I just missing
something?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11273#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list