[wp-trac] [WordPress Trac] #9751: Let's do not rush things for upcomming PHP minimum version PHP 5.x.y

[WordPress Trac]

#9751: Let's do not rush things for upcomming PHP minimum version PHP 5.x.y
--------------------------------------------------+-------------------------
 Reporter:  hakre                                 |        Owner:  anonymous
     Type:  task (blessed)                        |       Status:  reopened 
 Priority:  normal                                |    Milestone:  2.9      
Component:  General                               |      Version:  2.8.4    
 Severity:  normal                                |   Resolution:           
 Keywords:  has-patch needs-testing dev-feedback  |  
--------------------------------------------------+-------------------------
Changes (by hakre):

  * keywords:  patch-added needs-testing  dev-feedback => has-patch needs-
               testing dev-feedback
  * version:  2.8.1 => 2.8.4


Comment:

 I've updated and modified the patch because of variaous resons:

  1. It didn't apply to trunk any longer
  2. I do not see any need to modfiy version.php which only adds another
 global while this is not needed for the one comparison function.
  3. The case of the php update after displaying a message was not
 reflected.
  4. The message did not reflect the actual php version. E.g. a php 3 user
 would get the php 4 message as well a php 5 user if php 5.2 becomes a
 requirement in the future.
  5. Dependencies (version to compare from/against) have been made
 injectable sothat it's possible to create tests w/o actually updating php
 within the test.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9751#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software