[wp-trac] [WordPress Trac] #10021: Unresponsive script errors on widgets screen
WordPress Trac
wp-trac at lists.automattic.com
Mon Aug 17 23:18:15 UTC 2009
#10021: Unresponsive script errors on widgets screen
-------------------------------------+--------------------------------------
Reporter: Denis-de-Bernardy | Owner: azaozz
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 2.9
Component: JavaScript | Version: 2.8
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Changes (by azaozz):
* priority: high => normal
* severity: major => normal
* milestone: 2.8.5 => 2.9
Comment:
Been testing this for a while. For an average widgets page with two
sidebars and about 40 widgets on a lower end PC the speed increase is
almost unnoticeable:
{{{
Firefox 3.5 195ms -> 125ms
Safari 4 120ms -> 92ms
Opera 9.6 830ms -> 640ms
IE6 1540ms -> 1130ms
}}}
(note how browsers without getElementsByClassName are a lot slower).
There's only a barely noticeable speed improvement in IE6, 0.4sec. Of
course the numbers change in extreme cases: 12 sidebars and 150 widgets
containing tables, etc.
Nevertheless this patch is a good idea and would fix some border cases
where the widgets page is huge, 1MB+.
The only problem as Denis mentions is that the current patch modifies all
internal widgets HTML IDs making them unusable for plugins and breaking
any plugin that uses them at the moment. This is done to speed up copying
the widget's title from the title field to the widget's header.
There's also a regression there as the title used to be appended when the
widget was saved too. Trying some workarounds for this but may eventually
need to put the old code back.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/10021#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list