[wp-trac] Re: [WordPress Trac] #9682: Move wp-login.php function definitions to pluggable.php

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 30 15:32:15 GMT 2009


#9682: Move wp-login.php function definitions to pluggable.php
--------------------------+-------------------------------------------------
 Reporter:  misterbisson  |       Owner:                                     
     Type:  enhancement   |      Status:  new                                
 Priority:  normal        |   Milestone:  2.8                                
Component:  Users         |     Version:  2.7.1                              
 Severity:  normal        |    Keywords:  has-patch needs-testing 2nd-opinion
--------------------------+-------------------------------------------------

Comment(by misterbisson):

 Putting the do_action() at the end of the switch doesn't allow plugins to
 override the built-in action functions. This is important because the
 existing functions really don't do what they need to for my application,
 and the actions don't help.

 problems:

 The retrieve_password_key action only gets fired if the
 user_activation_key in the users table is empty.

 The $key stored in the users table never expires (so far as I can tell).

 The $key stored in the users table will be re-used for future password
 resets (as far as I can tell).

 The password_reset action happens after the $key has been validated
 (preventing plugins from doing their own validation/expiration).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9682#comment:10>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list