[wp-trac] Re: [WordPress Trac] #6969: Don't apply wptexturize() to
the insides of shortcode tags
WordPress Trac
wp-trac at lists.automattic.com
Wed Apr 29 17:30:57 GMT 2009
#6969: Don't apply wptexturize() to the insides of shortcode tags
--------------------------+-------------------------------------------------
Reporter: Viper007Bond | Owner: tellyworth
Type: enhancement | Status: new
Priority: normal | Milestone: 2.8
Component: Formatting | Version: 2.5.1
Severity: normal | Keywords: has-patch needs-testing
--------------------------+-------------------------------------------------
Comment(by Denis-de-Bernardy):
A few thoughts:
- I'm scratching my head on the extra parameter in the
get_shortcode_regexp(), when using the original one might be just as good.
- the start regexp is not the same as the beginning of the real regex
- the idea of changing the actual regexp using str_replace() seems a
little weird. why not make it the first element and re-assign things as
needed later on?
also, I foresee potential bugs or tough choices due to the fact that
shortcodes can now be escaped like this:
{{{
[[shortcode]]
}}}
because of the escaping regex, the current patch seems potentially buggy:
{{{
foo[shortcode]
"bar"
[/shortcode]foo
}}}
--
Ticket URL: <http://core.trac.wordpress.org/ticket/6969#comment:14>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list