[wp-trac] Re: [WordPress Trac] #6593: Tags with custom slugs get recreated on post edit screen

WordPress Trac wp-trac at lists.automattic.com
Tue Apr 28 23:56:13 GMT 2009


#6593: Tags with custom slugs get recreated on post edit screen
--------------------------------------------------+-------------------------
 Reporter:  jhodgdon                              |        Owner:  ryan    
     Type:  defect (bug)                          |       Status:  reopened
 Priority:  normal                                |    Milestone:  2.8     
Component:  Taxonomy                              |      Version:  2.5     
 Severity:  normal                                |   Resolution:          
 Keywords:  ag custom slug duplicity needs-patch  |  
--------------------------------------------------+-------------------------
Changes (by jhodgdon):

  * keywords:  reporter-feedback => ag custom slug duplicity needs-patch


Comment:

 I just tested this in 2.8-bleeding [11116].

 Summary: Most of the reproduce options above are fixed, but there is still
 one that doesn't work.

 Details:

 The original reproduce from the bug description has been fixed for a long
 time, and is still fixed in 2.8-bleeding.

 The Japanese reproduce from comment:18 above appears to be fixed too.

 The San Andreas / Vice City issue from comment:19 above appears to be
 fixed too.

 The Japanese reproduce form comment:23 above appears to be fixed too.

 The C/C++ reproduce from comment:31 above appears to be fixed too.

 However, the reproduce from comment:30 is still a problem. Steps:

 a) Create a tag on the Post Tags screen
 Name: Man's Relationship To The Divine
 Slug: man_divine

 b) Edit a post. Add this tag using the tag area of the screen (start
 typing Man, select from drop-down list).

 c) Save the post.

 d) Return to the tag manage screen and you will see two copies of the
 Man's Relationship to the Divine tag there (the new one has slug mans-
 relationship-to-the-divine).

 So it appears that tags with apostrophes are still broken.

 You know, this whole issue with tags would go away if the tag add section
 worked like category add -- behind the scenes, using the term ID rather
 than the term name as the identifier. Or use the term slug. Either way, it
 would be much more robust, and would also allow the term names to be
 filtered when displayed in the tag add area (good for multilingual sites).
 This would require a total rewrite of the tag section, but I think it
 would be a good idea. You'd have to think hard about what to do for non-JS
 users...

 One more comment on this idea of total rewrite. As it is, the "choose from
 most used tags" functionality does not work with multilingual plugins
 right now, because the tag cloud is displaying filtered names. That would
 be OK, but those displayed names are then what is saved to the "add tags"
 area. And that doesn't work -- in order for this matching to work when the
 post is saved, it needs to save the raw, unfiltered names to the tag add
 area. If what was really being used behind the scenes was the tag slug or
 the tag ID, then this problem would not be present.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/6593#comment:40>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list