[wp-trac] Re: [WordPress Trac] #9647: initial taxonomies

WordPress Trac wp-trac at lists.automattic.com
Tue Apr 28 11:20:15 GMT 2009


#9647: initial  taxonomies
--------------------------+-------------------------------------------------
 Reporter:  arena         |       Owner:  ryan                   
     Type:  defect (bug)  |      Status:  new                    
 Priority:  high          |   Milestone:  2.8                    
Component:  Taxonomy      |     Version:  2.8                    
 Severity:  normal        |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------

Comment(by arena):

 @Ryan, @Denis-de-Bernardy : agree with all your comments,

 * about register_taxonomy() :
   + should initialize $wp_taxonomies if not set
           if (!is_array($wp_taxonomies)) $wp_taxonomies = array();
   + maybe adding following test
           if (isset($wp_taxonomies[$taxonomy])) return;

 * about #9399 patch,
   + create_initial_taxonomies() should use register_taxonomy().
   + add_action( 'init', 'create_initial_taxonomies' );  should have the
 highest priority to be executed before any other add_action( 'init' ...

 * about wp-settings.php
   + load_default_textdomain() should be moved further up in wp-
 settings.php (apparently only needs constant WP_LANG_DIR).
   + maybe create_initial_taxonomies() code should be in wp-settings.php
 and we would get rid of the "add_action( 'init',
 'create_initial_taxonomies' );" .

 I am still a bit concerned about existing plugins that are doing things on
 wordpress "plugins_loaded" event. They could even define some new
 taxonomies that will be erased by the #9399 patch's "add_action( 'init',
 'create_initial_taxonomies' );" .

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9647#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list