[wp-trac] Re: [WordPress Trac] #9549: WP should catch serialization errors in options and meta fields

[WordPress Trac]

#9549: WP should catch serialization errors in options and meta fields
------------------------------------+---------------------------------------
 Reporter:  Denis-de-Bernardy       |        Owner:  anonymous
     Type:  defect (bug)            |       Status:  reopened 
 Priority:  normal                  |    Milestone:  2.8      
Component:  General                 |      Version:  2.8      
 Severity:  critical                |   Resolution:           
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------
Changes (by hakre):

  * status:  closed => reopened
  * resolution:  fixed =>
  * severity:  normal => critical


Comment:

 Let's assume that is_serialized() does a propper job, then I can live with
 that patch. But it does not #9663. Additionally that wild-guessing about
 MBCS and strlen() vs. unserialize really gets on my nerves. Please link
 hard facts on having a bug there in PHP core or leave it. but guessing
 around does not help to get these really hard bugs out of the core.

 Having users overload functions while not knowing what they do is their
 fault. Developers must at least stick with the default implementation, you
 can't take responsibility for environments where stuff is massivly
 overloaded and therefore re-defined.

 So I must say (and I did that in the past) maybe_serialize() and
 maybe_unserialize() should be a pair. The last changeset did break that
 pattern. This might lead to even more problems, therefore I reopen the
 ticket and suggest to revert the last change.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9549#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software