[wp-trac] Re: [WordPress Trac] #9569: Installing over existing user table gives misleading instruction

[WordPress Trac]

#9569: Installing over existing user table gives misleading instruction
-------------------------+--------------------------------------------------
 Reporter:  coffee2code  |       Owner:                  
     Type:  enhancement  |      Status:  new             
 Priority:  lowest       |   Milestone:  2.8             
Component:  Upgrade      |     Version:  2.8             
 Severity:  trivial      |    Keywords:  has-patch tested
-------------------------+--------------------------------------------------

Comment(by coffee2code):

 Attaching an alternative implementation of the patch.  Just about as
 simple, but more generic, and probably good enough to warrant closing the
 ticket if committed.  No longer compare the returned random password with
 a separate copy of the phrase indicating an existing password was
 inherited, which is a potentially brittle check as the phrase could be
 changed in one place but not the other.

 Instead, simply check the potentially generated password for a space
 character.  A space character is not a valid password character.  Its
 presence would indicate a phrase or sentence of some sort was returned,
 therefore the instruction to note the password need not be shown.  This
 allows for the message to be changed without needing to change anything
 here.  Also, some other error message could just as well be returned and
 things will still behave as expected.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9569#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software