[wp-trac] Re: [WordPress Trac] #8603: post_parent default in get_children

[WordPress Trac]

#8603: post_parent default in get_children
--------------------------+-------------------------------------------------
 Reporter:  jdub          |       Owner:  anonymous             
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  2.7.2                 
Component:  General       |     Version:  2.7                   
 Severity:  normal        |    Keywords:  has-patch dev-feedback
--------------------------+-------------------------------------------------

Comment(by filosofo):

 I think this should be "won't fix."

 If you want all attachments, there's a clearer, more direct way of getting
 them.

 If you're trying address problems for plugins that were relying on pre-2.7
 behavior of get_children to get all attachments, those plugins have
 already had to make changes for 2.7.x. So it's too late to help them.  Not
 to mention that the behavior they relied on worked only when just the
 right arguments were supplied (in other words, even back then having an
 empty post parent didn't produce all attachments for every possible set of
 arguments; that's what I mean by "inconsistent").

 And there's the semantic stuff I mentioned above: "children" or "child"
 everywhere else in WP implies a hierarchical relationship that doesn't
 exist in the "get all attachments" scenario.  If null really acted as a
 wildcard, that would be one thing, but it behaves only somewhat like a
 wildcard and only in certain situations.  The harm in reverting to the
 previous behavior is that it eliminates a default and introduces
 inconsistent behavior to get_children.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8603#comment:9>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software