[wp-trac] Re: [WordPress Trac] #3962: WordPress should adjust for
DST ("location" appropriate)
WordPress Trac
wp-trac at lists.automattic.com
Fri Apr 17 22:17:27 GMT 2009
#3962: WordPress should adjust for DST ("location" appropriate)
----------------------------+-----------------------------------------------
Reporter: iacas | Owner: anonymous
Type: task (blessed) | Status: reopened
Priority: high | Milestone: 2.8
Component: Administration | Version: 2.1.2
Severity: normal | Resolution:
Keywords: needs-testing |
----------------------------+-----------------------------------------------
Comment(by sambauers):
Replying to [comment:73 ryan]:
> Does auto suggest work only for the English strings?
No, it will pull suggestions from the english and the translated strings.
> It seems we should store the zoneinfo string to the DB and not our made
up string.
The relationship isn't one to one, so if we store say "Europe/London" the
user could have initially entered "Cardiff - Wales", "Edinburgh -
Scotland" or "London - England". Which means we we try to display the
users initial setting we can only guess as to what they put in there in
the first place. By storing the english string (not the translated string)
we can put people back where they were.
> We should also only show an entry if it is in zoneinfo. Not all
zoneinfo installs have everything. zoneinfo should be authoritative, not
our array.
The mappings from the pretty names to zoneinfo are to very safe zoneinfo
entries which should be in every install. In any case the zoneinfo entry
that is chosen is always tested for validity.
> Suggest a tz only if it is in zoneinfo. Allow someone to input a plain
tz string not in our list as long as it is in zoneinfo.
That is possible now... try entering Australia/Sydney, it works.. try
entering Foo/Bar, it fails.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/3962#comment:75>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list