[wp-trac] Re: [WordPress Trac] #8444: Quick Editing a Child Page makes it appear to not be a child any more

[WordPress Trac]

#8444: Quick Editing a Child Page makes it appear to not be a child any more
-------------------------------------+--------------------------------------
 Reporter:  Otto42                   |        Type:  defect (bug)
   Status:  new                      |    Priority:  low         
Milestone:  2.8                      |   Component:  Quick Edit  
  Version:  2.7                      |    Severity:  normal      
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Changes (by jbsil):

  * keywords:  => has-patch needs-testing


Comment:

 The immediate problem here was that the AJAX call only includes a single
 page, and if that page is a child, its parent is not included, so the
 function assumes it is an orphan and provides level 0.

 This patch rechecks the level if ($level == 0 && (int)$page->post_parent >
 0)
 When the correct level is determined, the returned row includes the
 correct number of dashes so the post remains/becomes/is no longer indented
 accordingly.

 This does bring up another related but much larger issue of not reordering
 pages after they are quick-edited to be children of a different page. The
 issue here is two fold: first, the page, now being (or no longer being) a
 child of another page, is almost guaranteed to be in the 'wrong' place in
 the list of pages. This cannot be solved easily, as any change to the list
 or paged view will result in a jarring user experience, likely seen as a
 bug. The second issue is that any children of the page that was just
 edited should likely also be relocated and/or have the number of dashes in
 their title changed.

 This patch does not address either issue, and I believe both issues are
 out of scope for this milestone, as discussed with azaozz in email
 correspondence. A refresh of the page (or navigation to a different
 paginated view, etc.) will display the relocated pages correctly.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8444#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software