[wp-trac] Re: [WordPress Trac] #7303: Theme preview generates duplicate `onclick` attribute

WordPress Trac wp-trac at lists.automattic.com
Fri Oct 24 09:42:44 GMT 2008


#7303: Theme preview generates duplicate `onclick` attribute
-------------------------------------------+--------------------------------
 Reporter:  Varsity                        |        Owner:  westi   
     Type:  defect                         |       Status:  assigned
 Priority:  normal                         |    Milestone:  2.7     
Component:  General                        |      Version:  2.6     
 Severity:  normal                         |   Resolution:          
 Keywords:  has-patch dev-feedback commit  |  
-------------------------------------------+--------------------------------
Changes (by DD32):

  * keywords:  needs-patch => has-patch dev-feedback commit

Comment:

 > attachment 7303.diff added.
  * strips out any onclicks
  * Makes sure not to break mid-attribute
    * eg. {{{onclick="test(\"test\")"}}} will be matched, rather than just
 {{{onclick="test(\"}}}
  * Only strips it out if onlick exists within the link, to prevent having
 to do backtracing for all links, Might possibly be overkill really.
  * onclicks before href are not matched due to the design of the
 functions, Perhaps that should be changed?

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7303#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list