[wp-trac] [WordPress Trac] #7947: Wrong "icon_dir" action

[WordPress Trac]

#7947: Wrong "icon_dir" action
---------------------+------------------------------------------------------
 Reporter:  jmini    |       Owner:  anonymous             
     Type:  defect   |      Status:  new                   
 Priority:  normal   |   Milestone:  2.8                   
Component:  General  |     Version:                        
 Severity:  trivial  |    Keywords:  icon_dir, icon_dir_uri
---------------------+------------------------------------------------------
 When I checked for "icon_dir" action I figure out there are 2 action :
  * '''icon_dir''' : absolut path to the icon set directory
  * '''icon_dir_uri''' : uri to the icon set directory
 (see a good example at lines 2612 and 2613 in
 [http://trac.wordpress.org/browser/trunk/wp-includes/post.php#L2612 wp-
 includes/post.php])

 In file [http://trac.wordpress.org/browser/trunk/wp-
 includes/media.php#L507 wp-includes/media.php on line 507] the wrong of
 this 2 actions is called.
 It should be '''icon_dir_uri''' instead of '''icon_dir''' in order to keep
 it logical:
 {{{
 $icon_dir = apply_filters( 'icon_dir_uri', includes_url('images/crystal')
 );
 }}}

 Otherwise if you want to hook icon_dir, you have to check if you are
 dealing with a path or a uri.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7947>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software