[wp-trac] Re: [WordPress Trac] #6489: Revisions do not respect time zone if offset differs between settings and server

[WordPress Trac]

#6489: Revisions do not respect time zone if offset differs between settings and
server
-----------------------------------------------+----------------------------
 Reporter:  sillybean                          |        Owner:  anonymous
     Type:  defect                             |       Status:  new      
 Priority:  high                               |    Milestone:  2.7      
Component:  Administration                     |      Version:  2.5      
 Severity:  major                              |   Resolution:           
 Keywords:  autosave revision timezone offset  |  
-----------------------------------------------+----------------------------
Changes (by janbrasna):

  * keywords:  autosave => autosave revision timezone offset
  * priority:  low => high
  * summary:  Autosave does not respect time zone offset => Revisions do
              not respect time zone if offset differs between
              settings and server
  * severity:  minor => major
  * milestone:  2.9 => 2.7

Comment:

 It's not only autosave, the whole revision system uses server time zone
 for display.

 I think that the severity is rather high, because it leads to using wrong
 versions or total confusion.

 Basically it's borked at the point when the datetime of a revision is
 retrieved via GMT since it's then converted via date_i18n to TZ of the
 server. Additionally any TZ info of the original revision is lost (imagine
 you change TZ for daylight savings and then the math via GMT fails to show
 the original time the revision was saved.) There's AFAIK no reason not to
 use the actual date with offset info from the DB for displaying it.

 Attaching patch, please review.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6489#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software