[wp-trac] Re: [WordPress Trac] #8300: Add parentheses to the list of valid URL characters for make_clickable function

WordPress Trac wp-trac at lists.automattic.com
Fri Nov 21 02:58:14 GMT 2008


#8300: Add parentheses to the list of valid URL characters for make_clickable
function
-------------------------+--------------------------------------------------
 Reporter:  josephscott  |        Owner:  anonymous
     Type:  defect       |       Status:  new      
 Priority:  normal       |    Milestone:  2.8      
Component:  General      |      Version:  2.7      
 Severity:  normal       |   Resolution:           
 Keywords:  has-patch    |  
-------------------------+--------------------------------------------------
Comment (by josephscott):

 Replying to [comment:1 DD32]:
 > You need to be careful about including parentheses in function to make
 links, As (http://blah.com/) should not be matched as a link, only the
 insides, yet http://blah.com/something(else)_another should..
 >
 > There are some link parsing regular expressions around which deal with
 those cases specifically, somethin more robust might be required.

 Just so happens that I just wrote some code to deal with this, so that
 this:

 {{{
 My site (http://josephscott.org)
 }}}

 So that the the open and closing parens are not included as part of the
 URL, will still supporting parens inside the URL.

 I've updated the patch to reflect this.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8300#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list