[wp-trac] Re: [WordPress Trac] #7001: Admin SSL Support

[WordPress Trac]

#7001: Admin SSL Support
---------------------+------------------------------------------------------
 Reporter:  ryan     |        Owner:  anonymous
     Type:  defect   |       Status:  new      
 Priority:  normal   |    Milestone:  2.6      
Component:  General  |      Version:           
 Severity:  normal   |   Resolution:           
 Keywords:           |  
---------------------+------------------------------------------------------
Comment (by tellyworth):

 I added some quick initial unit tests in TestSSLLinks:

 http://svn.automattic.com/wordpress-tests/wp-
 testcase/test_link_functions.php

 Some quick suggestions:

 * is_ssl() should do a case insensitive check on the value

 * the block of code for fetching the base URL with http/https should be a
 separate function, it'll be useful elsewhere

 * caching the base value in $_wp_admin_url makes it difficult to test (and
 introduces unexpected behaviour: if siteurl changes, admin_url() should
 reflect that change)

 * behaviour for invalid $path values should be defined and it needs
 validation

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7001#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software