[wp-trac] Re: [WordPress Trac] #6262: Automatic Plugin Upgrade could break new plugins that require special instructions for upgrading

[WordPress Trac]

#6262: Automatic Plugin Upgrade could break new plugins that require special
instructions for upgrading
--------------------------------------+-------------------------------------
 Reporter:  nerrad                    |        Owner:  anonymous
     Type:  defect                    |       Status:  new      
 Priority:  high                      |    Milestone:  2.5      
Component:  Administration            |      Version:  2.5      
 Severity:  major                     |   Resolution:           
 Keywords:  dev-feedback 2nd-opinion  |  
--------------------------------------+-------------------------------------
Comment (by DD32):

 Allright.

 I've written up some changes, Now plugins are deactivated during the
 upgrade process(Just before files are modified), And reactivation is
 attempted after the upgrade proceedure completes.

 The activation hooks run during activation, so plugins can hook upgrade
 functionality, however, interactive upgrade wizard or something wouldnt be
 encouraged as it runs within a small iframe(170px high).

 Deactivation hooks are NOT run, as the plugin isnt being killed off, and
 certain plugins are known to hook the deactivation to redirect the user
 elsewhere to remove all settings.. It also prevents some plugins from
 clearing their cached files, And since the plugin isnt being actually
 deactivated, it makes sense to me.

 I'll post a patch tomorrow after some attention has been given to another
 patch thats needed first.


 (So yes, "DD32, why do we need to ask if a plugin should be re-activated
 after being moved? Can't we assume that?", your right, if it was
 previously activated, might as well go ahead and activate it again.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6262#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software