[wp-trac] Re: [WordPress Trac] #6239: Mulit-widget widget addition broken with JS turned off.

WordPress Trac wp-trac at lists.automattic.com
Mon Mar 17 23:17:03 GMT 2008


#6239: Mulit-widget widget addition broken with JS turned off.
----------------------+-----------------------------------------------------
 Reporter:  mdawaffe  |        Owner:  mdawaffe
     Type:  defect    |       Status:  assigned
 Priority:  normal    |    Milestone:  2.5     
Component:  General   |      Version:  2.5     
 Severity:  normal    |   Resolution:          
 Keywords:  widgets   |  
----------------------+-----------------------------------------------------
Changes (by mdawaffe):

  * owner:  anonymous => mdawaffe
  * status:  new => assigned
  * summary:  Mulitwidget widget addition broken with JS turned off. =>
              Mulit-widget widget addition broken with JS
              turned off.

Comment:

 With the current code, it is essentially impossible to add a multi-widget
 instance without going through a POST request.

 For non-JS users, the attached patch inserts an intermediate page load
 between clicking "Add" on a multi-widget and seeing the new instance of
 that multi-widget showing up in the "Current Widgets" list.  This
 intermediate page lets the user fill out the form fields for that instance
 of the multi-widget and lets WP process a POST request.

 Attached also:
  1. Cleans up a potential PHP warning.
  2. Makes it possible for non-JS users to edit the first widget in the
 "Current Widgets" list.
  3. Makes it possible for non-JS users to remove widgets from the "Current
 Widgets" list.
  4. Adds nonce check to widget's "Save Changes" POST request (oops!).

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6239#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list