[wp-trac] Re: [WordPress Trac] #5081: make_clickable shouldn't
include trailing punctuation
WordPress Trac
wp-trac at lists.automattic.com
Sat Mar 15 09:51:23 GMT 2008
#5081: make_clickable shouldn't include trailing punctuation
----------------------------------------+-----------------------------------
Reporter: matt | Owner: neodude
Type: defect | Status: assigned
Priority: normal | Milestone: 2.5
Component: General | Version: 2.3
Severity: minor | Resolution:
Keywords: has-patch needs-unit-tests |
----------------------------------------+-----------------------------------
Changes (by westi):
* keywords: has-patch => has-patch needs-unit-tests
Comment:
I think we can strip the valid but only informative . off the end of
domain names being made clickable as having it/not having it shouldn't
make any difference to how the link is interpreted.
The patch looks good - I think it would be good to add some tests to the
unit test suite for this as well to prove it works well for all cases.
--
Ticket URL: <http://trac.wordpress.org/ticket/5081#comment:8>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list