[wp-trac] Re: [WordPress Trac] #5886: Text Widget - Cancel link doesn't work

[WordPress Trac]

#5886: Text Widget - Cancel link doesn't work
-----------------------------------+----------------------------------------
 Reporter:  Otto42                 |        Owner:  mdawaffe
     Type:  defect                 |       Status:  assigned
 Priority:  normal                 |    Milestone:  2.5     
Component:  General                |      Version:  2.5     
 Severity:  normal                 |   Resolution:          
 Keywords:  has-patch 2nd-opinion  |  
-----------------------------------+----------------------------------------
Changes (by mdawaffe):

  * keywords:  => has-patch 2nd-opinion

Comment:

 5886.diff disables widget form elements on cancel so that the canceled
 changes are not saved.

 What it does.
  1. Load the widget page.
  2. Click "Edit" on a widget.  Make some change.  Click "Cancel".
  3. Click "Save Changes" on the bottom.
  4. Notice that the changes you canceled were not saved.  The content is
 the same as when you first loaded the page.

 It's not perfect.
  1. Load the widget page.
  2. Click "Edit" on a widget.  Make some change.  Click "Change".
  3. Re-edit that widget by again clicking "Edit" on that widget. Make some
 more changes.  Click "Cancel"
  4. Click "Save Changes" on the bottom.
  5. Notice that no changes were saved.  The content is the same as when
 you first loaded the page.  One might have expected the first change you
 made to be saved (you didn't cancel that change), but the second to be
 discarded.

 To fix that bug, we'd either have to store old states of widgets in JS, or
 have the "Change" and "Cancel" buttons do ajax requests (which would
 implement [comment:3 bryan868`s recommendation]).  Unless this is marked
 as a high priority, neither of those things is going to happen this late
 in the game.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5886#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software