[wp-trac] Re: [WordPress Trac] #5770: Add extra options for default tag-cloud widget

[WordPress Trac]

#5770: Add extra options for default tag-cloud widget
----------------------------+-----------------------------------------------
 Reporter:  AndrewFrazier   |        Owner:  anonymous
     Type:  enhancement     |       Status:  new      
 Priority:  normal          |    Milestone:  2.6      
Component:  Administration  |      Version:  2.5      
 Severity:  normal          |   Resolution:           
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Comment (by DD32):

 > Or at least, if it's not going in, of someone coming along and telling
 me my code sucks?

 Cant say why its not gone in, However, On your code:
  * $optionss should probably be merged with $args somehow
  * Theres no need to translate defaults( {{{__()}}} and {{{_e()}}} are
 translatable strings)
  * For defaults, Look into wp_parse_args() and the way $defaults are used
 elsewhere.

 Finally: I was going to update your patch so it took into consideration
 those, But the patch needs to be refreshed(recreated) on a later branch,
 As it is, The patcher is getting confused as to which changes need to be
 made..

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5770#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software