[wp-trac] Re: [WordPress Trac] #6943: Published Pages are set to private after saving

[WordPress Trac]

#6943: Published Pages are set to private after saving
----------------------------+-----------------------------------------------
 Reporter:  imwebgefunden   |        Owner:  jeremyclarke
     Type:  defect          |       Status:  new         
 Priority:  high            |    Milestone:  2.5.2       
Component:  Administration  |      Version:  2.5.1       
 Severity:  major           |   Resolution:              
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Changes (by jeremyclarke):

 * cc: jeremyclarke, imwebgefunden (added)
  * keywords:  edit pages, published pages, publish_pages,
               edit_published_pages => has-patch
  * owner:  anonymous => jeremyclarke

Comment:

 This came up in [7070], and I spent some time looking at the problem to
 try and figure it out. It turns out that there are several things wrong
 with the edit-page-form.php file that never really got fixed even though
 parallel problems were fixed in the edit-form-advanced.php file.

 One is that at some point the dropdown menu for post status stopped
 showing a 'private' status option labeled 'published' and started just
 using the published option (and controlled the override on the backend).
 My patch addresses this change for the page form as well.

 The other two problems that are adressed in the old patches are also
 addressed in mine and I think with a bit more subtlety based on my testing
 for [7070]. .

  * Status should only get shunted if the user can't publish a new page or
 if they don't have edit_published_pages and it's already published. (in
 wp-admin/includes/post.php)

  * The publish dropdown menu item should only show if the user can publish
 pages, or if the page is already published and they can re-publish this
 page (with the post ID, the edit_page capability takes care of the
 details).

 I also set the privacy checkbox to only show if the user has
 'publish_posts' capability to match the posts screen. It may make sense to
 have a more subtle check for this as well, but I don't really care and I
 think i'ts more important that pages and posts match.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6943#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software