[wp-trac] Re: [WordPress Trac] #7391: forbiddance of ini_set('include_path', ...) function causes fatal error at revision feature

[WordPress Trac]

#7391: forbiddance of ini_set('include_path', ...) function causes fatal error at
revision feature
-------------------------------+--------------------------------------------
 Reporter:  codestyling        |        Owner:  anonymous
     Type:  defect             |       Status:  new      
 Priority:  high               |    Milestone:  2.6.1    
Component:  General            |      Version:  2.6      
 Severity:  blocker            |   Resolution:           
 Keywords:  reporter-feedback  |  
-------------------------------+--------------------------------------------
Comment (by azaozz):

 Replying to [comment:6 jacobsantos]:
 > Should probably return WP_Error() instead of a string. However, I'm not
 going to dig down into the wp-admin structure in order to make that work.
 Yes, was thinking to return WP_Error and change revision.php so it can
 handle errors.

 Don't think a conditional is needed here. If a host has disabled
 set_include_path() why would they leave ini_set() enabled. Also what's the
 purpose of running restore_include_path() at this point? The include path
 may have been extended before wp_text_diff() was called and restoring it
 to default may break another function.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7391#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software