[wp-trac] Re: [WordPress Trac] #4579: IPv6 IPs

[WordPress Trac]

#4579: IPv6 IPs
------------------------------------------------+---------------------------
 Reporter:  xiand0                              |        Owner:  westi   
     Type:  defect                              |       Status:  reopened
 Priority:  low                                 |    Milestone:  2.5     
Component:  General                             |      Version:          
 Severity:  minor                               |   Resolution:          
 Keywords:  has-patch ipv6 tested dev-feedback  |  
------------------------------------------------+---------------------------
Comment (by westi):

 Replying to [comment:24 ruckus]:
 > [6658] only changes one of the two instances where filtering takes
 place.
 >

 Why on earth that code is there twice I don't know.  It makes no sense!

 > I still think it would be sufficient to just escape the data before
 inserting in the database, no other filtering necessary.
 >

 Not really as we want IPs rather than just safe data in that field.

 > If we do filtering, we should document why the different characters are
 allowed.  I don't see how space and comma would ever be in REMOTE_ADDR.

 As I have said above. AFAIK it is perfectly possible for REMOTE_ADDR to
 have a list of addresses in it - for example if the incoming request comes
 via a chain of proxy servers.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4579#comment:25>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software