[wp-trac] Re: [WordPress Trac] #3089: Localized values for plugin
metadata
WordPress Trac
wp-trac at lists.automattic.com
Thu Jan 24 22:00:41 GMT 2008
#3089: Localized values for plugin metadata
-------------------------------------+--------------------------------------
Reporter: nbachiyski | Owner: ryan
Type: enhancement | Status: new
Priority: normal | Milestone: 2.5
Component: i18n | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+--------------------------------------
Comment (by jhodgdon):
I tested the patch submitted by darkdragon. It sort of worked. I fixed it
up so that it worked for me.
Issues:
- Name, description, etc. needed to be trimmed before translation
- I got errors from the l10n.php file, because even if the plugin did
not provide a text domain, and preg_replace returned false, the match
array $text_domain was being set (at least on my test server, running PHP
5). So instead of checking to see if the $text_domain array has been set,
I thought it was better to use the return value of preg_replace to see if
translation should be done.
I'll attach the patch... this one works for me.
--
Ticket URL: <http://trac.wordpress.org/ticket/3089#comment:19>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list