[wp-trac] Re: [WordPress Trac] #5427: WordPress should not include a file indicated by a URL query string that has not been specified in an add_submenu_page call

[WordPress Trac]

#5427: WordPress should not include a file indicated by a URL query string that
has not been specified in an add_submenu_page call
----------------------------------------+-----------------------------------
 Reporter:  johnbillion                 |        Owner:  anonymous
     Type:  defect                      |       Status:  new      
 Priority:  normal                      |    Milestone:  2.6      
Component:  Administration              |      Version:  2.3.1    
 Severity:  normal                      |   Resolution:           
 Keywords:  add_submenu_page has-patch  |  
----------------------------------------+-----------------------------------
Changes (by DD32):

  * keywords:  add_submenu_page needs-patch => add_submenu_page has-patch

Comment:

 Attached a patch which checks to see if the page being loaded has been
 specified as a Top level page, or as a submenu page.

 If a user attempts to direct it to a page which is not registered as being
 a menu, it die's with a message.

 This could cause problems with plugins which link to pages via the admin
 pages which do not have a set submenu page. I doubt there are many plugins
 which would do that, And those that do, Should register a callback and
 include the file that way instead.

 I was unsure where to put the validate function, If anyone thinks it
 should be commited, i'll add PHPDoc.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5427#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software