[wp-trac] Re: [WordPress Trac] #5768: Warning: closedir(): supplied argument is not a valid Directory resource in /wp-includes/theme.php on line 166

[WordPress Trac]

#5768: Warning: closedir(): supplied argument is not a valid Directory resource in
/wp-includes/theme.php on line 166
---------------------------------------------------------------+------------
 Reporter:  dustinsilva                                        |        Owner:  anonymous
     Type:  defect                                             |       Status:  closed   
 Priority:  normal                                             |    Milestone:  2.6      
Component:  Optimization                                       |      Version:  2.3.2    
 Severity:  blocker                                            |   Resolution:  fixed    
 Keywords:  closedir, warning, not valid directory, theme.php  |  
---------------------------------------------------------------+------------
Comment (by DD32):

 Shouldnt've the change been applied here:
 http://trac.wordpress.org/browser/trunk/wp-includes/theme.php#L135

 It should fail to open the theme directory and then return false if its
 not a valid directory.. Perhaps a is_dir() should've been added there
 instead?

 While i'm on that piece of code: http://trac.wordpress.org/browser/trunk
 /wp-includes/theme.php#L159
 {{{
 || $theme_dir == 'CVS' )
 }}}
 Shouldn't that be checking for subversion stuff instead now-days?(if even
 needed)

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5768#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software