[wp-trac] Re: [WordPress Trac] #7592: index.php doesn't generate 404's

WordPress Trac wp-trac at lists.automattic.com
Mon Dec 29 13:31:38 GMT 2008


#7592: index.php doesn't generate 404's
--------------------------+-------------------------------------------------
 Reporter:  btmorex       |        Owner:  anonymous
     Type:  defect (bug)  |       Status:  new      
 Priority:  normal        |    Milestone:  2.8      
Component:  General       |      Version:  2.6.1    
 Severity:  normal        |   Resolution:           
 Keywords:                |  
--------------------------+-------------------------------------------------
Comment (by DD32):

 Thoughts:
  * Canonical redirection could take place to remove the extra args
   * Which will cause problems for plugins which rely on extra $_GET args
  * ?error=404 will not work with pretty permalinks, if a rule is matched,
 $error gets ignored..  The codex page will refering to those who use non-
 rewrite rules mainly i would expect
   * This probably needs to be corrected, if $_GET['error'] is set, short
 circuit the rewrite rules checks maybe, That appears to work and while it
 sets it to a 404 condition, it still queries the posts for the front page.
    * change line 147 of classes.php to {{{if (! empty($rewrite) &&
 !isset($_GET['error']) ) {}}} for that
  * index.php?blahblahblah=vlbfgdfg shouldnt create 404 pages, its a
 legitimate request, quite possibly handled by a plugin


 So other than possibly making ?error=404 working for permalinks, Thats the
 only defect i see in this ticket, and even then, its more likely a
 enhancement, since if PW was using rewrites, then it wouldnt need to have
 that handler in the .htaccess; I have a feeling that codex page might just
 contain a lot of ancient (Pre 2.0?) information.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/7592#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list