[wp-trac] Re: [WordPress Trac] #8627: Emoticons count as links in comments

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 19 21:15:12 GMT 2008


#8627: Emoticons count as links in comments
----------------------------------------------+-----------------------------
 Reporter:  mtdewvirus                        |        Owner:  tott 
     Type:  defect (bug)                      |       Status:  new  
 Priority:  normal                            |    Milestone:  2.7.1
Component:  Comments                          |      Version:  2.7  
 Severity:  normal                            |   Resolution:       
 Keywords:  comment moderation link emoticon  |  
----------------------------------------------+-----------------------------
Comment (by Otto42):

 Fix: Change the regular expression to this:

 {{{
 |(href\t*?=\t*?['\"]?)(https?:)?//|i
 }}}


 Eliminate that center question mark. If we're applying the comment_text
 filter first, then any unlinked http uris will have been autolinked
 already, meaning that the href= will exist around them. Making it not
 necessary for it to be optional.

 This will also eliminate the false positive on an img src="http:whatever"

-- 
Ticket URL: <http://trac.wordpress.org/ticket/8627#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list