[wp-trac] Re: [WordPress Trac] #6476: 2.5 Gallery shortcode orderby not working

[WordPress Trac]

#6476: 2.5 Gallery shortcode orderby not working
---------------------------+------------------------------------------------
 Reporter:  GeoffHarrison  |        Owner:  anonymous
     Type:  defect         |       Status:  reopened 
 Priority:  normal         |    Milestone:  2.5.1    
Component:  General        |      Version:  2.5      
 Severity:  normal         |   Resolution:           
 Keywords:  has-patch      |  
---------------------------+------------------------------------------------
Comment (by markjaquith):

 I'd use "rand" and "ID" for consistency with orderby code in
 {{{query.php}}}  We can go through on another ticket and make similar code
 test a lowercase version of the orderby param and test both "rand" and
 "random"

 I also wouldn't call it {{{sanitize_orderby()}}} -- it's not sanitization
 as much as it is translation from one format to another.
 {{convert_human_orderby_to_sql()}}} or something.

 Replying to [comment:16 Dickie]:
 > What about backwards compatibility for those who have already started
 using
 > `[gallery orderby="<something> ASC, <also> DESC"]` in 2.5 ?
 >
 > Maybe it's not that many?

 orderby doesn't work currently, so it's not like we'd be breaking it for
 them!

-- 
Ticket URL: <http://trac.wordpress.org/ticket/6476#comment:17>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software