[wp-trac] Re: [WordPress Trac] #5103: Non localized strings in wp-includes/comment-template.php

[WordPress Trac]

#5103: Non localized strings in wp-includes/comment-template.php
-------------------------------------------------+--------------------------
 Reporter:  RanYanivHartstein                    |        Owner:  nbachiyski
     Type:  defect                               |       Status:  closed    
 Priority:  normal                               |    Milestone:            
Component:  i18n                                 |      Version:  2.3       
 Severity:  normal                               |   Resolution:  invalid   
 Keywords:  has-patch needs-testing 2nd-opinion  |  
-------------------------------------------------+--------------------------
Changes (by nbachiyski):

  * status:  new => closed
  * resolution:  => invalid
  * milestone:  2.4 =>

Comment:

 Unfortunately, PHP doesn't allow default argument values to be function
 calls:
 {{{
 The default value must be a constant expression, not (for example) a
 variable,
 a class member or a function call.
 }}}
 from
 [http://bg2.php.net/manual/en/functions.arguments.php#functions.arguments.default
 Function arguments].

 Themes should take care of i18n of these strings, themselves, giving i18n-
 ed factual arguments when calling the function, like this:
 {{{
 comment_type(__('Comment'), __('Trackback'), __('Pingback'));
 }}}

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5103#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software