[wp-trac] Re: [WordPress Trac] #4916: comment_type function doesn't return the comment type string

[WordPress Trac]

#4916: comment_type function doesn't return the comment type string
---------------------------------------+------------------------------------
 Reporter:  hudatoriq                  |        Owner:  westi     
     Type:  defect                     |       Status:  assigned  
 Priority:  normal                     |    Milestone:  2.4 (next)
Component:  General                    |      Version:  2.3       
 Severity:  normal                     |   Resolution:            
 Keywords:  comment reporter-feedback  |  
---------------------------------------+------------------------------------
Changes (by westi):

  * status:  new => assigned
  * milestone:  2.3 => 2.4 (next)

Comment:

 Replying to [comment:6 hudatoriq]:
 > So.. where are we going to?

 I had a chat on irc the other day with nbachiyski:

 {{{
 08:24 < nikolayb> looking at it
 08:24 < westi|wah> I wonder wether the code in comment_type should be in
 get_comment_type so that you can call that with the translatable strings
 08:26 < nikolayb> I think that all echoing template functions should only
 do echo get_<the-function>
 08:28 < nikolayb> I guess get_comment_type is used for other things also
 08:28 < westi|wah> yeah i'm thinking that would make more sense..
 08:28 < nikolayb> in other contexts I mean
 08:28 < nikolayb> so we can
 08:28 < nikolayb> so we can't easily change it
 08:28 < westi|wah> all get_comment_type does though is give you
 $comment->comment_type at present
 08:29 < westi|wah> changing it could cause issues though
 08:29 < nikolayb> don't spam plugins use it?
 08:29 < westi|wah> possibly - i would hope they didn't though as it is
 really a template tag
 08:29 < nikolayb> we can add another function in the middle:
 get_comment_type_text or something
 08:29 < nikolayb> and comment_type would echo its value
 08:31 < westi|wah> that sounds sensible
 }}}

 Moving this to 2.4 as it needs more work to resolve.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4916#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software