[wp-trac] Re: [WordPress Trac] #4899: Create wp-includes/class
folder to store WordPress classes Proposal
WordPress Trac
wp-trac at lists.automattic.com
Mon Sep 3 23:27:42 GMT 2007
#4899: Create wp-includes/class folder to store WordPress classes Proposal
------------------------------+---------------------------------------------
Reporter: darkdragon | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4 (next)
Component: General | Version: 2.3
Severity: normal | Resolution:
Keywords: classes proposal |
------------------------------+---------------------------------------------
Comment (by darkdragon):
Replying to [comment:4 Viper007Bond]:
> Replying to [comment:1 darkdragon]:
> > Oh yeah, class files shouldn't include optional ending PHP tag.
>
> Bad practice IMO and a dirty hack, one that's not needed since these
files shouldn't be edited by the user. It's somewhat understandable for a
config file or whatnot, but it's pointless for files like this.
The debate on whether or not the closing tag should or should not be used
is not conclusive and is more a matter of preference. It is only a "dirty
hack" if all included files don't have trailing spaces. In the event that
any file does and the user tries to use header after including said file,
problems might or might not occur. See #4901 patch for files that do (said
patch does nothing however).
--
Ticket URL: <http://trac.wordpress.org/ticket/4899#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list