[wp-trac] Re: [WordPress Trac] #5131: wp_tag_cloud(): title='1 topics', should be 1 topic

[WordPress Trac]

#5131: wp_tag_cloud(): title='1 topics', should be 1 topic
-------------------------+--------------------------------------------------
 Reporter:  atppp        |        Owner:  anonymous
     Type:  enhancement  |       Status:  new      
 Priority:  normal       |    Milestone:  2.5      
Component:  General      |      Version:  2.3      
 Severity:  normal       |   Resolution:           
 Keywords:               |  
-------------------------+--------------------------------------------------
Comment (by webrocker):

 Replying to [comment:3 Nazgul]:
 > This patch kills right-to-left language support.
 Ooops. Is this because of the way how the digit is 'handwired' in front of
 the 'topics' label (like '1 topic'), whereas a right-to-left needs
 something like 'topic 1'? In the original it is {{{sprintf( __('%d
 topics'), $count )}}}, so the digit is in front of the label anyway?
 Sorry, I don't get the difference between a hardcoded 'topics' after the
 %d and the variable used in my patch {{{sprintf( __('%d '.$topictxt),
 $count )}}}.

 Replying to [comment:4 foolswisdom]:
 > Please don't set the milestone, leave that for a core contributor.
 Ok, sorry for that.

 Replying to [comment:5 westi]:
 > Indeed, patch should be reworked to use
 [http://trac.wordpress.org/browser/trunk/wp-includes/l10n.php#L50
 __ngettext] rather than !__

 well the original used !__ , so I didn't messed with that.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5131#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software