[wp-trac] [WordPress Trac] #5376: rules added via mod_rewrite_rules should be in IfModule section

[WordPress Trac]

#5376: rules added via mod_rewrite_rules should be in IfModule section
------------------------+---------------------------------------------------
 Reporter:  mastermind  |       Owner:  anonymous                    
     Type:  defect      |      Status:  new                          
 Priority:  normal      |   Milestone:  2.5                          
Component:  General     |     Version:  2.3.1                        
 Severity:  normal      |    Keywords:  mod_rewrite mod_rewrite_rules
------------------------+---------------------------------------------------
 When mod_rewrite rules are added via the filter {{{mod_rewrite_rules}}},
 the rules should be inserted within the {{{<IfModule
 mod_rewrite.c></IfModule>}}} tags. At the moment, this is not the case,
 instead they are appended outside this section.

 This shouldn't be a problem on most hosts. Still, it's ugly, and it should
 be easy to fix by putting the line {{{$rules .= "</IfModule>\n";}}} just
 before the return argument in the {{{function mod_rewrite_rules()}}} in
 {{{wp-includes/rewrite.php}}} (i.e. after the filters are applied).

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5376>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software