[wp-trac] Re: [WordPress Trac] #5338: Preformance Tweaks for WordPress Trunk Plugin API, plugin.php

[WordPress Trac]

#5338: Preformance Tweaks for WordPress Trunk Plugin API, plugin.php
--------------------------------------------------------+-------------------
 Reporter:  darkdragon                                  |        Owner:  anonymous
     Type:  enhancement                                 |       Status:  new      
 Priority:  normal                                      |    Milestone:  2.5      
Component:  Optimization                                |      Version:  2.4      
 Severity:  normal                                      |   Resolution:           
 Keywords:  plugins.php phpdoc has-patch needs-testing  |  
--------------------------------------------------------+-------------------
Changes (by darkdragon):

  * keywords:  plugins.php phpdoc needs-patch => plugins.php phpdoc has-
               patch needs-testing

Comment:

 I don't know if you want the PHPDoc stuff, I'll remove it, but it does
 improve upon some of the stuff from the other bugs (#5163 and #5225).
 Unintentionally, since I've used the one for the PHPdoc checkout instead
 of the other checkout (I've so many now, I can't keep track of which ones
 are broken and what I've used them for).

 Basically, it is important since there is a merged filters bug in the
 do_actions (the $merged_filters isn't being set to global, therefore the
 test will always fail and decrease performance. Won't break anything, but
 could slow things down by sorting the array each time.)

 I've removed the '@' from the current filter assignment, which should
 speed things up, since '@' is slow until latest PHP 5.2 version (5.2.3 or
 5.2.4 has the performance improvement).

 I moved the all tag call to its own function and updated all functions to
 call it instead. The function has PHPDoc info. You will notice that the
 hook is not part of the call, I figure using the current_filter function
 is better.

  * I did not use Foreach instead of the do while.
  * I did not remove merged_filters
  * I did not move current_filters assignment.

 All in all, I've only did two of the five things in the WP-Hackers post.
 The rest were premature.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5338#comment:16>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software