[wp-trac] Re: [WordPress Trac] #5298: https atom service document doesn't point to https collections

WordPress Trac wp-trac at lists.automattic.com
Tue Nov 6 19:12:22 GMT 2007


#5298: https atom service document doesn't point to https collections
-----------------------+----------------------------------------------------
 Reporter:  rubys      |        Owner:  westi   
     Type:  defect     |       Status:  assigned
 Priority:  normal     |    Milestone:  2.4     
Component:  General    |      Version:  2.3.1   
 Severity:  normal     |   Resolution:          
 Keywords:  has-patch  |  
-----------------------+----------------------------------------------------
Comment (by westi):

 Replying to [comment:5 rubys]:
 > Am I misreading line 20 in {{{xmlrpc.php}}} incorrectly?  The intent of
 this patch is to only do this check when fetching the {{{rsd}}} document.
 >
 > See [http://intertwingly.net/blog/2007/10/31/WordPress-SSL-TLS-and-
 AtomPub this post] for background.  Some place in the traversal from
 {{{http://foo.wordpress.com/}}} => {{{xmlrpc.php?rsd}}} => {{{/wp-
 app.php/service}}} => {{{/wp-app.php/posts}}} or {{{/wp-
 app.php/attachments}}} there needs to be an indication that {{{https}}}
 should be used.  Doing this when rendering the front-page would clearly be
 overkill.  Doing it on every fetch of the service document would be
 better.  Doing it only when fetching the discovery document seems (to me
 at least) to be better yet.

 Sorry - I read the patch too quick :-( Indeed this does only apply when we
 are returning the rsd.

 I think i would be happier if we moved the check for https availablity out
 to a generic function and then just had an apply_filter call in xmlrpc.php
 so that a plugin could force a https url without the run-time cost of the
 check if the admin knows that https is available for accessing the blog.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5298#comment:6>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list