[wp-trac] [WordPress Trac] #5312: wp-admin/includes/image.php
overhaul
WordPress Trac
wp-trac at lists.automattic.com
Sat Nov 3 08:14:26 GMT 2007
#5312: wp-admin/includes/image.php overhaul
----------------------------+-----------------------------------------------
Reporter: DD32 | Owner: anonymous
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: Administration | Version: 2.4
Severity: normal | Keywords: has-patch
----------------------------+-----------------------------------------------
This ticket relates to #4151, #4709 and #5304
I've cleaned the file up to reduce duplicated code, Added PHPDoc comments,
and included mentioned tickets within the cleanup.
Notes:[[BR]]
* {{{function get_udims()}}} duplicated {{{wp_shrink_dimensions()}}},
Switched it to use {{{wp_shrink_dimensions()}}} instead.[[BR]]
* It appears that {{{get_udims()}}} is not used anywhere else in WP.[[BR]]
* depreciated 3rd param($effect) to {{{wp_create_thumbnail()}}} as it isnt
used within the function.[[BR]]
* IMAGETYPE_XXX introduced with PHP 4.3.0 it appears, Added to
compat.php.[[BR]]
* The inline documentation may not be the best, And doesnt include Long
descriptions for most of the functions.[[BR]]
* Most functions should return a WP_Error object instead on error, For
most compatibilit current patch follows previous error handling route.
--
Ticket URL: <http://trac.wordpress.org/ticket/5312>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list