[wp-trac] [WordPress Trac] #4246: link-manager.php - invalid variable (typo)

[WordPress Trac]

#4246: link-manager.php - invalid variable (typo)
----------------------------+-----------------------------------------------
 Reporter:  charismabiz     |       Owner:  anonymous
     Type:  defect          |      Status:  new      
 Priority:  normal          |   Milestone:  2.4      
Component:  Administration  |     Version:  2.1.2    
 Severity:  normal          |    Keywords:           
----------------------------+-----------------------------------------------
 '''Wordpress Version''': WordPress 2.1.2 (also checked that 2.1.3 has the
 same bug)[[BR]]
 '''Problem File''': wp-admin/link-manager.php[[BR]]
 '''Problem Line''': Line 183[[BR]]
 '''Problem''': The variable $id is not defined (ie: var_dump($id)=NULL).
 Based on preceding code and documentation in Codex about how it's supposed
 to work, I think it should be $link->link_id[[BR]]
 '''Reason for fixing''': Required for those who are making plugins
 relating to the blogroll administration. Also, why leave a typo like that
 in?[[BR]]


 '''Original Code (Line 183)''':[[BR]]
 <td><?php do_action('manage_link_custom_column', $column_name, $id);
 ?></td>

 '''Proposed solution (Line 183)''':[[BR]]
 <td><?php do_action('manage_link_custom_column', $column_name,
 $link->link_id); ?></td>


 '''Error is confirmed to appear on''' (it should appear always, since it's
 a code flaw/typo):[[BR]]
 WordPress 2.1.2[[BR]]
 Windows NT 5.1 build 2600[[BR]]
 Apache/2.2.4 (Win32) (API Version: 20051115)[[BR]]
 PHP Version 5.2.1[[BR]]
 mySQL 5.0.37[[BR]]
 Browser: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3)
 Gecko/20070309 Firefox/2.0.0.3[[BR]]

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4246>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software