[wp-trac] Re: [WordPress Trac] #4169: Bring widgets into WordPress core

[WordPress Trac]

#4169: Bring widgets into WordPress core
-----------------------------+----------------------------------------------
 Reporter:  rob1n            |        Owner:  rob1n   
     Type:  task             |       Status:  reopened
 Priority:  highest omg bbq  |    Milestone:  2.2     
Component:  General          |      Version:          
 Severity:  blocker          |   Resolution:          
 Keywords:                   |  
-----------------------------+----------------------------------------------
Comment (by ryan):

 Widgets written against the plugin version of widgets do this:

 register_widget_control($name, $i <= $number ?
 'widget_adsense_control' : /* unregister */ '', 460, 350, $i);

 Insead of:

 register_widget_control($name, $i <= $number ?
 'widget_adsense_control' : /* unregister */ '', 460, 350, $id, $i);

 $i is being interpreted as an ID and mucking things up.

 Distinguishing the intent of that fifth arg, whether it be
 an ID or an arbitrary arg being passed along, is difficult.  Do we
 need to have separate funcs for old and new?

 Old:
 function register_widget_control($name, $control_callback, $width =
 300, $height = 200, ...)

 New:
 function wp_register_widget_control($id, $name, $control_callback,
 $width = 300, $height = 200, ...)

 The same for [wp_]register_sidebar_widget().  And update the
 plugin with all of the changes we've done in core so that 2.0 and 2.1
 users have it.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4169#comment:51>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software