[wp-trac] Re: [WordPress Trac] #4029: maybe_serialize() can do double-serialize

WordPress Trac wp-trac at lists.automattic.com
Mon Mar 26 05:12:39 GMT 2007


#4029: maybe_serialize() can do double-serialize
------------------------------------+---------------------------------------
 Reporter:  takayukister            |        Owner:  anonymous
     Type:  defect                  |       Status:  reopened 
 Priority:  normal                  |    Milestone:  2.2      
Component:  General                 |      Version:  2.2      
 Severity:  major                   |   Resolution:           
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------
Comment (by takayukister):

 I am sorry but I found that my first patch may cause another problem.

 Original maybe_serialize() does not apply serialization to plain (not
 serialized) string, so there are many plain string values existing in
 options, postmeta and usermeta tables. My patched maybe_serialize()
 reverse the behavior and serialize all the plain strings.

 If there are codes or plugins that access directly to that tables and
 expect to get plain string value, they may fail.

 I'm sorry for my carelessness. I think it would be good to make another
 patches if necessary.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4029#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list