[wp-trac] [WordPress Trac] #3928: add_query_arg() without assignment in upload.php

[WordPress Trac]

#3928: add_query_arg() without assignment in upload.php
----------------------------+-----------------------------------------------
 Reporter:  markjaquith     |       Owner:  mdawaffe
     Type:  task            |      Status:  new     
 Priority:  low             |   Milestone:  2.2     
Component:  Administration  |     Version:  2.2     
 Severity:  normal          |    Keywords:          
----------------------------+-----------------------------------------------
 {{{trunk/wp-admin/upload.php:88-94}}}

 {{{
 echo "<ul id='upload-menu'>\n";
 foreach ( $wp_upload_tabs as $t => $tab_array ) { // We've already done
 the current_user_can check
         $href = add_query_arg( array('tab' => $t, 'ID' => '', 'action' =>
 '', 'paged' => '') );
         if ( isset($tab_array[4]) && is_array($tab_array[4]) )
                 add_query_arg( $tab_array[4], $href );
         $_href = attribute_escape( $href);
         $page_links = '';
 }}}

 That second {{{add_query_arg()}}} call isn't assigning to anything, so it
 doesn't do anything.

 I have no symptoms to report at this time... just noticed that it looked
 wrong.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3928>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software