[wp-trac] Re: [WordPress Trac] #4509: Add parameters to wp_list_pages defaults

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 22 13:57:39 GMT 2007


#4509: Add parameters to wp_list_pages defaults
----------------------------+-----------------------------------------------
 Reporter:  MichaelH        |        Owner:  anonymous
     Type:  defect          |       Status:  new      
 Priority:  low             |    Milestone:           
Component:  Administration  |      Version:  2.3      
 Severity:  minor           |   Resolution:           
 Keywords:                  |  
----------------------------+-----------------------------------------------
Comment (by Otto42):

 -1. Functions should only define as defaults what they actually use
 themselves. A default should not be added because a lower level function
 (get_pages in this case) uses it. Those defaults should be in get_pages
 instead.

 The idea is that parameters can pass through to lower level functions,
 yes, but you don't have to add the defaults to higher level functions to
 do that unless there's a parameter naming conflict of some sort.

 Leave documentation in the codex where it belongs. Don't document the code
 unless you're doing it with comments.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4509#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list