[wp-trac] Re: [WordPress Trac] #3996: MAGPIE_USER_AGENT lack of wp version

[WordPress Trac]

#3996: MAGPIE_USER_AGENT lack of wp version
-------------------------------------------+--------------------------------
 Reporter:  hakre                          |        Owner:  anonymous
     Type:  enhancement                    |       Status:  reopened 
 Priority:  normal                         |    Milestone:  2.2.2    
Component:  Template                       |      Version:  2.1.2    
 Severity:  normal                         |   Resolution:           
 Keywords:  rss magpie snoopy needs-patch  |  
-------------------------------------------+--------------------------------
Changes (by westi):

  * keywords:  rss magpie snoopy => rss magpie snoopy needs-patch
  * resolution:  invalid =>
  * status:  closed => reopened
  * component:  Administration => Template
  * milestone:  => 2.2.2

Comment:

 I understand this issue.

 The fact is that rss.php is included in a number of places:

 http://trac.wordpress.org/browser/trunk/wp-includes/widgets.php#L935
 http://trac.wordpress.org/browser/trunk/wp-includes/widgets.php#L1006
 http://trac.wordpress.org/browser/trunk/wp-admin/index-extra.php#L3

 Only the last of these is at global scope.

 Therefore in the two widgets cases $wp_version will not be defined - php
 requires and includes get the scope of the line of code on which they
 occur.

 We therefore need to fix the implicit use of globals in rss.php or include
 it at global scope in widgets.php

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3996#comment:7>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software