[wp-trac] Re: [WordPress Trac] #4671: Empty ul in RSS widget when only a title present

[WordPress Trac]

#4671: Empty ul in RSS widget when only a title present
-----------------------+----------------------------------------------------
 Reporter:  brettz95   |        Owner:  anonymous  
     Type:  defect     |       Status:  new        
 Priority:  normal     |    Milestone:  2.3 (trunk)
Component:  General    |      Version:  2.2.1      
 Severity:  normal     |   Resolution:             
 Keywords:  has-patch  |  
-----------------------+----------------------------------------------------
Changes (by Nazgul):

  * keywords:  => has-patch
  * version:  2.3 => 2.2.1
  * component:  Administration => General
  * milestone:  => 2.3 (trunk)

Comment:

 2.3 has not yet been released, so I assume you're running 2.2.1, the
 latest stable release.

 Patch looks good. 2 small suggestions though:[[br]]
 * You're mixing print and echo. I'd prefer only echo as thats the standard
 throughout the codebase.[[br]]
 * You could combine the exisiting is_array and new is_empty into a single
 if statement. This would result in a smaller and cleaner patch.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4671#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software